Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator minimum commission #81

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Conversation

the-frey
Copy link
Collaborator

@the-frey the-frey commented Nov 8, 2021

Upgrade handler in the vein of osmo solution, ante fix ported from stargaze.

Attempt to close off #17 so that we can test and ship with moneta.
Needs tagging as v2.0.0-beta if/when approved.

@giansalex
Copy link
Member

giansalex commented Nov 8, 2021

I see it as a temporary solution

cosmos/cosmos-sdk#10422 maybe we can see this later

@the-frey
Copy link
Collaborator Author

the-frey commented Nov 8, 2021

@giansalex yep, when that gets merged we can switch over. In the meantime, we need to get validators on 5% ASAP, so would be nice to get this in with moneta if poss 🙏

Even when the SDK upgrade is in with the param, I think we'd need to run the upgrade in order to force existing validators to adhere to the gov decision, so the upgrade handler is needed regardless (I think).

Copy link
Contributor

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for testnet usage. I really am not in love with this solution and it feels a bit funny to me.

That said, I do not think that it will explode things and I do think that it will get the job done.

@JakeHartnell JakeHartnell merged commit e6ea1e9 into main Nov 10, 2021
@JakeHartnell JakeHartnell deleted the validator_minimum_commission branch November 10, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants